Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infinite recursion issue #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

ceddlyburge
Copy link
Owner

I'm hoping SonarQube will analyse this code and add some shizzle to the pull request.

{

}

void InfiniteRecusrion()
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKER Add a way to break out of this method's recursion. rule

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo. Should be "InfiniteRecursion" :) It would be great if sonar could catch typos like this.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha ha! I totally hadn't spotted that! I've committed a fix.

There is the Spell Checker plugin, but it only works with Java, and I don't think it works with the latest version of SonarQube,

@ceddlyburge
Copy link
Owner Author

SonarQube analysis reported 1 issue

  • BLOCKER 1 blocker

Watch the comments in this conversation to review them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants